Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform command-line arguments passed by anaconda project #133

Merged
merged 2 commits into from Oct 31, 2018

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 31, 2018

This PR helps transform arguments that may be passed to the panel console script that would not be accepted by bokeh without transformation.

@jbednar
Copy link
Member

@jbednar jbednar commented Oct 31, 2018

Note that using --allow-websocket-origin in this way requires bokeh 0.12.7 or later, which anaconda-project itself can't do (as it is meant to work with any Bokeh version, even though it doesn't currently), but it should be ok here because Panel requires a later version of bokeh anyway.

@jbednar jbednar merged commit aa77cf8 into master Oct 31, 2018
2 checks passed
@jbednar jbednar deleted the commandline_update branch Oct 31, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 31, 2018

Codecov Report

Merging #133 into master will increase coverage by 0.03%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   89.88%   89.92%   +0.03%     
==========================================
  Files          27       28       +1     
  Lines        4153     4178      +25     
==========================================
+ Hits         3733     3757      +24     
- Misses        420      421       +1
Impacted Files Coverage Δ
panel/tests/test_cli.py 100% <100%> (ø)
panel/cli.py 90.9% <94.73%> (+24.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ddbd6...3a339d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants