Improvements for ipywidgets support #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
reviewed
Jun 9, 2020
| msg = self.msg(msg_type, content=content, parent=parent, header=header, metadata=metadata) | ||
| msg['channel'] = stream.channel | ||
|
|
||
| doc = self._document |
There was a problem hiding this comment.
I would add:
@property
def document(self):
return curdoc()in ipywidgets_bokeh and override it here with self._document. Similar thing can be done with even trigger, and all this code duplication could be avoided.
There was a problem hiding this comment.
Right I was going to make a PR on ipywidgets_bokeh to reduce code duplication.
|
@mattpap I've pushed this PR: bokeh/ipywidgets_bokeh#13 which will allow me to reduce code duplication here. For now I'll merge and will remove the code duplication once a new ipywidgets_bokeh release is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had supported using ipywidgets in the notebook (using the regular Jupyter CommManager) and on the server using ipywidgets_bokeh. I had however overlooked the case where you start a server inside the notebook, e.g. when using
.show(). This PR provides a custom IPyKernel to be used in such scenarios, when rendering a plot with.show()the kernel on each Comm is updated to point to this custom kernel allowing communication on the server even when it has been launched inside a notebook.