Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended parser to support pyct commands #176

Merged
merged 3 commits into from Dec 4, 2018
Merged

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Dec 4, 2018

Addresses #109. It isn't obvious how to do the right thing here but this seems to me like the easiest way to splice together two external parsers. It does mean if you mistype 'serve', then it is the pyct parser that will complain.

jbednar
jbednar approved these changes Dec 4, 2018
Copy link
Member

@jbednar jbednar left a comment

Looks great, thanks!

panel/cli.py Show resolved Hide resolved
jbednar and others added 2 commits Dec 4, 2018
Added docstring to main function

Co-Authored-By: jlstevens <jlrstevens@gmail.com>
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 4, 2018

Codecov Report

Merging #176 into master will decrease coverage by 0.14%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   90.07%   89.92%   -0.15%     
==========================================
  Files          30       30              
  Lines        4746     4755       +9     
==========================================
+ Hits         4275     4276       +1     
- Misses        471      479       +8
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
panel/cli.py 67.74% <16.66%> (-23.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938e5da...08fe53d. Read the comment docs.

bokeh_entry_point()
def main(args=None):
"""Special case: Allow Bokeh to handle the `serve` command; rest is handled by pyct."""
if len(sys.argv) > 1 and 'serve' == sys.argv[1]:
Copy link
Member

@philippjfr philippjfr Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'serve' the only bokeh command we are supporting?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 4, 2018

I'll merge, I'm not sure if we should support any bokeh commands other than serve but we should at least decide deliberately.

@philippjfr philippjfr merged commit ba46bff into master Dec 4, 2018
2 checks passed
@jbednar
Copy link
Member

@jbednar jbednar commented Dec 5, 2018

The commands currently offered by Bokeh are:

$ bokeh --help
usage: bin/bokeh [-h] [-v] {html,info,json,png,sampledata,secret,serve,static,svg} ...

positional arguments:
  {html,info,json,png,sampledata,secret,serve,static,svg}
                        Sub-commands
    html                Create standalone HTML files for one or more applications
    info                print information about Bokeh and Bokeh server configuration
    json                Create JSON files for one or more applications
    png                 Create standalone PNG files for one or more applications
    sampledata          Download the bokeh sample data sets
    secret              Create a Bokeh secret key for use with Bokeh server
    serve               Run a Bokeh server hosting one or more applications
    static              Serve bokehjs' static assets (JavaScript, CSS, images, fonts,
                        etc.)
    svg                 Create standalone SVG files for one or more applications

I'm happy to be corrected, but I don't think there is any use for info or sampledata; people can call bokeh directly for those. I don't personally know any use for json or static, but someone who knows more might. secret, html, png, and svg sound useful to me, and something potentially useful for panel to provide.

@jbednar jbednar deleted the parser_improvements branch Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants