Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fixes for example packaging #177

Merged
merged 3 commits into from Dec 5, 2018
Merged

Possible fixes for example packaging #177

merged 3 commits into from Dec 5, 2018

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Dec 5, 2018

Attempt to fix issue where the examples aren't in the package and panel examples isn't working.

@codecov-io
Copy link

@codecov-io codecov-io commented Dec 5, 2018

Codecov Report

Merging #177 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #177     +/-   ##
=========================================
- Coverage   89.91%   89.81%   -0.1%     
=========================================
  Files          30       30             
  Lines        4758     4763      +5     
=========================================
  Hits         4278     4278             
- Misses        480      485      +5
Impacted Files Coverage Δ
setup.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6769fba...fb62cb7. Read the comment docs.


example_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
'panel','examples')
if 'develop' not in sys.argv:
Copy link
Member

@philippjfr philippjfr Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really get this, develop installs the project in place which means you're basically just copying the files to the same location.

Copy link
Member

@philippjfr philippjfr Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my mistake, missed the not.

@philippjfr philippjfr merged commit 7384722 into master Dec 5, 2018
2 checks passed
@philippjfr philippjfr deleted the packaging_pyct branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants