Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToogleButtons : fix bug on empty list value #188

Merged
merged 3 commits into from Dec 26, 2018
Merged

ToogleButtons : fix bug on empty list value #188

merged 3 commits into from Dec 26, 2018

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Dec 26, 2018

Fix #186
Add test

@codecov-io
Copy link

@codecov-io codecov-io commented Dec 26, 2018

Codecov Report

Merging #188 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   89.81%   89.82%   +<.01%     
==========================================
  Files          30       30              
  Lines        4763     4766       +3     
==========================================
+ Hits         4278     4281       +3     
  Misses        485      485
Impacted Files Coverage Δ
panel/tests/test_widgets.py 100% <100%> (ø) ⬆️
panel/widgets.py 95.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7384722...28a2248. Read the comment docs.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 26, 2018

Looks good to me, I'll merge once tests pass.

@philippjfr philippjfr merged commit 0a96e72 into holoviz:master Dec 26, 2018
1 check passed
@xavArtley xavArtley deleted the empty_toggle_buttons branch Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants