Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Group Modifications #189

merged 7 commits into from Dec 27, 2018

Toggle Group Modifications #189

merged 7 commits into from Dec 27, 2018


Copy link

@xavArtley xavArtley commented Dec 26, 2018

PR following discussion in #185

Discussion on choices I made is open.
I let some classes with deprecation warning which should appear in tests

I updated the Widgets notebook with Toggle Group example.

Copy link

@codecov-io codecov-io commented Dec 26, 2018

Codecov Report

Merging #189 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
+ Coverage   89.88%   90.06%   +0.18%     
  Files          30       30              
  Lines        4783     4872      +89     
+ Hits         4299     4388      +89     
  Misses        484      484
Impacted Files Coverage Δ
panel/tests/ 100% <100%> (ø) ⬆️
panel/ 95.62% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3d9ea...51bdd74. Read the comment docs.

Copy link

@DancingQuanta DancingQuanta commented Dec 27, 2018

You did a much better job than I could!

panel/ Outdated

class RadioButtons(CheckBoxGroup):

__doc__ = "Deprecated!!! see ToggleGroup"
Copy link

@philippjfr philippjfr Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be proper docstrings? i.e.:

class RadioButtons(CheckBoxGroup):
    Deprecated, use ToggleGroup instead.

Copy link

@philippjfr philippjfr commented Dec 27, 2018

Thanks so much for this. I've made one comment but am otherwise happy to merge.

Copy link
Collaborator Author

@xavArtley xavArtley commented Dec 27, 2018

I'm making the correction

@philippjfr philippjfr merged commit 13d40f0 into holoviz:master Dec 27, 2018
1 check passed
@xavArtley xavArtley deleted the toggle_changes branch Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants