Toggle Group Modifications #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 89.88% 90.06% +0.18%
==========================================
Files 30 30
Lines 4783 4872 +89
==========================================
+ Hits 4299 4388 +89
Misses 484 484
Continue to review full report at Codecov.
|
|
You did a much better job than I could! |
philippjfr
reviewed
Dec 27, 2018
panel/widgets.py
Outdated
|
|
||
| class RadioButtons(CheckBoxGroup): | ||
|
|
||
| __doc__ = "Deprecated!!! see ToggleGroup" |
There was a problem hiding this comment.
Can these be proper docstrings? i.e.:
class RadioButtons(CheckBoxGroup):
"""
Deprecated, use ToggleGroup instead.
"""
…sts on wrong initialisation
|
Thanks so much for this. I've made one comment but am otherwise happy to merge. |
|
I'm making the correction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR following discussion in #185
Discussion on choices I made is open.
I let some classes with deprecation warning which should appear in tests
I updated the Widgets notebook with Toggle Group example.