Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key error fix #190

Merged
merged 2 commits into from Dec 27, 2018
Merged

Key error fix #190

merged 2 commits into from Dec 27, 2018

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Dec 27, 2018

Fixes: #179, #180

  • 1 test of the problem

@codecov-io
Copy link

@codecov-io codecov-io commented Dec 27, 2018

Codecov Report

Merging #190 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   89.82%   89.88%   +0.05%     
==========================================
  Files          30       30              
  Lines        4766     4783      +17     
==========================================
+ Hits         4281     4299      +18     
+ Misses        485      484       -1
Impacted Files Coverage Δ
panel/param.py 90.46% <100%> (+0.39%) ⬆️
panel/tests/test_layout.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a96e72...81d10fb. Read the comment docs.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 27, 2018

Thanks so much for tracking this down.

@philippjfr philippjfr merged commit cc3d9ea into holoviz:master Dec 27, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants