Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace special characters of player.ts by their unicode equivalent #209

Merged
merged 2 commits into from Jan 10, 2019
Merged

Replace special characters of player.ts by their unicode equivalent #209

merged 2 commits into from Jan 10, 2019

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Jan 10, 2019

Fix #208
Ensure windows compatibility
A simple test which failed on windows was trying to open().read() player.ts file

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 10, 2019

Codecov Report

Merging #209 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   90.12%   90.13%   +0.01%     
==========================================
  Files          31       32       +1     
  Lines        4942     4949       +7     
==========================================
+ Hits         4454     4461       +7     
  Misses        488      488
Impacted Files Coverage Δ
panel/tests/test_models.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9421adb...813f982. Read the comment docs.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 10, 2019

Thanks!

@philippjfr philippjfr merged commit cbd1491 into holoviz:master Jan 10, 2019
2 checks passed
@jbednar jbednar changed the title Replace special charactere of player.ts by their unicode equivalent Replace special characters of player.ts by their unicode equivalent Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants