Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed precedence to priority and deleted trailing whitespace #235

Merged
merged 1 commit into from Feb 8, 2019

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 8, 2019

PR title says it all. I find using precedence for panes horribly confusing:

  1. Panel uses parameters with defined precedence internally.
  2. Panel sorts on parameter precedence when building widgets for parameterized objects.
  3. Panel applies panes according to its own notion of precedence.

Now if you grep for precedence, you know that the only concept there relates to parameters.

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 8, 2019

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files          34       34           
  Lines        5351     5351           
=======================================
  Hits         4817     4817           
  Misses        534      534
Impacted Files Coverage Δ
panel/tests/test_pipeline.py 99.27% <ø> (ø) ⬆️
panel/vega.py 82.85% <100%> (ø) ⬆️
panel/param.py 90.46% <100%> (ø) ⬆️
panel/plotly.py 100% <100%> (ø) ⬆️
panel/holoviews.py 84.1% <100%> (ø) ⬆️
panel/pane.py 82.5% <91.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb71e7...2f639c1. Read the comment docs.

@philippjfr philippjfr merged commit cb36c0a into master Feb 8, 2019
3 checks passed
@philippjfr philippjfr deleted the precedence_rename branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants