Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model and root handling #259

Merged
merged 7 commits into from Mar 3, 2019
Merged

Refactor model and root handling #259

merged 7 commits into from Mar 3, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 1, 2019

This PR tries to minimize the amount of nesting widgets and panes use, i.e. objects that can be updated inplace do not need to be nested inside a container. Only objects where the bokeh model is not well defined and therefore may need to be replaced entirely need to be nested.

This makes testing simpler, makes the bokeh model structure match the panel structure more closely and makes things easier for bokeh's layouts.

@philippjfr philippjfr changed the title Correctly expand Param pane Refactor model and root handling Mar 3, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 3, 2019

Codecov Report

Merging #259 into master will decrease coverage by 0.31%.
The diff coverage is 97.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   89.12%   88.81%   -0.32%     
==========================================
  Files          34       34              
  Lines        5436     5336     -100     
==========================================
- Hits         4845     4739     -106     
- Misses        591      597       +6
Impacted Files Coverage Δ
panel/interact.py 73.38% <0%> (+0.27%) ⬆️
panel/tests/test_vega.py 96.61% <100%> (-0.36%) ⬇️
panel/tests/test_panes.py 94.36% <100%> (-1.12%) ⬇️
panel/vega.py 83.33% <100%> (+0.47%) ⬆️
panel/tests/test_interact.py 100% <100%> (ø) ⬆️
panel/tests/test_layout.py 99.16% <100%> (-0.84%) ⬇️
panel/widgets.py 94.02% <100%> (-0.1%) ⬇️
panel/plotly.py 100% <100%> (ø) ⬆️
panel/tests/test_param.py 99.61% <100%> (ø) ⬆️
panel/tests/test_plotly.py 97.59% <100%> (-0.24%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c746e6d...63e17b1. Read the comment docs.

@philippjfr philippjfr merged commit 06660fa into master Mar 3, 2019
3 checks passed
@philippjfr philippjfr deleted the param_expand branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants