Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored server handling #276

Merged
merged 9 commits into from Mar 6, 2019
Merged

Refactored server handling #276

merged 9 commits into from Mar 6, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 5, 2019

This PR refactors the server handling such that all existing methods that start a bokeh server simply call the new Viewable.get_server method and then publish the server session in different ways. This also means that we now take full control over embedding servers inline in the notebook, which makes it possible to automatically clean up server sessions as cells are deleted or re-executed.

Depends on new versions of both the JLab extension and pyviz_comms: holoviz/pyviz_comms#28

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 5, 2019

Codecov Report

Merging #276 into master will decrease coverage by 0.52%.
The diff coverage is 31.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   88.25%   87.73%   -0.53%     
==========================================
  Files          58       59       +1     
  Lines        5712     5754      +42     
==========================================
+ Hits         5041     5048       +7     
- Misses        671      706      +35
Impacted Files Coverage Δ
panel/models/plots.py 100% <100%> (ø) ⬆️
panel/pane/holoviews.py 82.35% <100%> (ø) ⬆️
panel/__init__.py 100% <100%> (+45.83%) ⬆️
panel/layout.py 95.2% <100%> (ø) ⬆️
panel/pane/base.py 85.88% <100%> (ø) ⬆️
panel/viewable.py 65.04% <19.23%> (-3.29%) ⬇️
panel/util.py 67.33% <23.52%> (-3.23%) ⬇️
panel/io.py 38% <38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f327c1b...c04b787. Read the comment docs.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 6, 2019

Fixes #231

@philippjfr philippjfr merged commit 901c7e7 into master Mar 6, 2019
3 checks passed
@philippjfr philippjfr deleted the server_reorg branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants