Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param formatting via the new label property #290

Merged
merged 4 commits into from Mar 8, 2019
Merged

Param formatting via the new label property #290

merged 4 commits into from Mar 8, 2019

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 8, 2019

Now that holoviz/param#319 is merged, there is no need for the label formatter in panel to format parameter names. Merging this PR will bump the param version requirements so I will update the pinning too.

panel/param.py Outdated Show resolved Hide resolved
panel/param.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 8, 2019

Should cut a new param dev release and pin that in this PR.

Co-Authored-By: jlstevens <jlrstevens@gmail.com>
panel/param.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 8, 2019

Codecov Report

Merging #290 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   88.73%   88.77%   +0.03%     
==========================================
  Files          60       60              
  Lines        6000     6021      +21     
==========================================
+ Hits         5324     5345      +21     
  Misses        676      676
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
panel/util.py 65.67% <ø> (-1.67%) ⬇️
panel/tests/test_util.py 100% <ø> (ø) ⬆️
panel/param.py 90.57% <100%> (+0.17%) ⬆️
panel/viewable.py 73.89% <0%> (+1.14%) ⬆️
panel/widgets/slider.py 94.08% <0%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c779f...df91de6. Read the comment docs.

@philippjfr philippjfr merged commit 5a9ee4b into master Mar 8, 2019
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants