Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue setting (Multi)Select value when options changed #291

Merged
merged 2 commits into from Mar 9, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 8, 2019

This fixes callbacks set on a MultiSelect widget which change the values. Due to the ordering of the watchers it can happen that the options change before the value change event has been propagated to the underlying bokeh model. Ideally we would have a way to elevate the precedence of watch calls which would allow us to order the watchers appropriately.

This PR simply addresses the symptom by skipping values that aren't found.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 8, 2019

Codecov Report

Merging #291 into master will increase coverage by 0.03%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   88.73%   88.76%   +0.03%     
==========================================
  Files          60       60              
  Lines        5973     5998      +25     
==========================================
+ Hits         5300     5324      +24     
- Misses        673      674       +1
Impacted Files Coverage Δ
panel/tests/test_widgets.py 100% <100%> (ø) ⬆️
panel/widgets/select.py 97.12% <87.5%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9ee4b...98cd29f. Read the comment docs.

@philippjfr philippjfr merged commit 8e0ef61 into master Mar 9, 2019
3 checks passed
@philippjfr philippjfr mentioned this pull request Mar 9, 2019
16 tasks
@philippjfr philippjfr deleted the fix_multi_select branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants