Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor callbacks to be initialized on instantiation #293

Merged
merged 19 commits into from Mar 11, 2019
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 9, 2019

Instead of creating callbacks per bokeh model this PR creates single callbacks on instantiation which update all existing models.

Fixes #292

  • Ensure all Select widgets allow both list and dict
  • Update ParamMethod pane
  • Update CrossSelector
  • Simplify _callbacks
  • Remove final flag on cleanup
  • Ensure correct parameters are watched
  • Write tests for HoloViews pane, updating of backend parameter, more tests
  • Add dedicated cleanup tests

@philippjfr philippjfr changed the title Started callback refactor Refactor callbacks to be initialized on instantiation Mar 9, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 10, 2019

Codecov Report

Merging #293 into master will increase coverage by 0.18%.
The diff coverage is 90.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   88.76%   88.94%   +0.18%     
==========================================
  Files          60       61       +1     
  Lines        5998     6117     +119     
==========================================
+ Hits         5324     5441     +117     
- Misses        674      676       +2
Impacted Files Coverage Δ
panel/io.py 38% <0%> (ø) ⬆️
panel/tests/test_vega.py 96.61% <100%> (ø) ⬆️
panel/tests/test_plotly.py 97.46% <100%> (-0.13%) ⬇️
panel/tests/test_interact.py 100% <100%> (ø) ⬆️
panel/tests/test_layout.py 100% <100%> (+0.34%) ⬆️
panel/tests/test_param.py 99.65% <100%> (+0.03%) ⬆️
panel/widgets/base.py 100% <100%> (ø) ⬆️
panel/pane/equation.py 83.58% <100%> (+0.24%) ⬆️
panel/tests/test_widgets.py 100% <100%> (ø) ⬆️
panel/tests/test_reactive.py 100% <100%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0ef61...3792684. Read the comment docs.

@philippjfr philippjfr merged commit 580b322 into master Mar 11, 2019
3 checks passed
@philippjfr philippjfr deleted the callback_refactor branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants