Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constructing empty HoloViews pane #307

Merged
merged 3 commits into from Mar 15, 2019
Merged

Allow constructing empty HoloViews pane #307

merged 3 commits into from Mar 15, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 14, 2019

Other Panes already allow an empty constructor but it seems like I overlooked HoloViews.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 14, 2019

Codecov Report

Merging #307 into master will increase coverage by 0.19%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   89.07%   89.27%   +0.19%     
==========================================
  Files          63       63              
  Lines        6565     6583      +18     
==========================================
+ Hits         5848     5877      +29     
+ Misses        717      706      -11
Impacted Files Coverage Δ
panel/tests/test_holoviews.py 99.21% <100%> (+0.03%) ⬆️
panel/pane/holoviews.py 83.88% <94.11%> (+0.55%) ⬆️
panel/pane/image.py 82.97% <0%> (+1.06%) ⬆️
panel/util.py 70.25% <0%> (+1.89%) ⬆️
panel/interact.py 75.09% <0%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4ccc7...639178b. Read the comment docs.

@philippjfr philippjfr merged commit b7c3a49 into master Mar 15, 2019
3 checks passed
@philippjfr philippjfr deleted the allow_hv_none branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants