Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for new bokeh layout system #32

Merged
merged 30 commits into from Mar 1, 2019
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 6, 2018

Currently bokeh layouts are going through a major refactor. This PR will try to maintain compatibility with that bokeh branch (bokeh/bokeh#8085) while staying up to date with panel master.

Things that need fixing:

  • Custom (Vega/Plotly) models broken
  • Widget sizing completely broken
  • Widgets (specifically sliders and buttons) often do not allocate enough vertical space especially when displayed on their own (need at least some padding)
  • Tabs are completely broken
  • Column/Rows do not update when children are modified
  • Widgets don't line up even if given same width/height
  • Button.clicks attribute was removed
  • "bk-widgetbox" css class is very ugly and does not improve spacing issues mentioned above
  • Widgets do not update in response to changes in their height/width

I'll be adding new items as I discover them and ticking off issues when they're fixed

@DancingQuanta
Copy link
Contributor

@DancingQuanta DancingQuanta commented Feb 4, 2019

Trying out Bokeh version 1.1.0dev2 with panel.Pipeline and changing the transition buttons' widths

pipeline = pn.pipeline.Pipeline(stages, debug=True)

# Change width of buttons
pipeline.layout[0][1]._widget_box.width = 100
pipeline.layout[0][2]._widget_box.width = 100

pipeline.layout.servable()

Modifying the widths have no effect with this version of bokeh.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Feb 4, 2019

This PR is pretty outdated, I'll probably push an entirely new PR for compatibility fixes and adding new features.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Feb 4, 2019

Modifying the widths have no effect with this version of bokeh.

I've already raised this issue upstream with bokeh.

@DancingQuanta
Copy link
Contributor

@DancingQuanta DancingQuanta commented Feb 4, 2019

Could you give the reference to bokeh issue please?

@philippjfr philippjfr force-pushed the bokeh_layout_changes branch 6 times, most recently from a6292e6 to 53864a2 Compare Feb 28, 2019
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 1, 2019

I'm going to merge this and further development can happen on new PRs.

@philippjfr philippjfr merged commit 2aedd25 into master Mar 1, 2019
2 of 3 checks passed
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 1, 2019

Codecov Report

Merging #32 into master will decrease coverage by 0.07%.
The diff coverage is 98.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   89.38%   89.31%   -0.08%     
==========================================
  Files          44       44              
  Lines        5474     5437      -37     
==========================================
- Hits         4893     4856      -37     
  Misses        581      581
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
panel/tests/test_interact.py 100% <100%> (ø) ⬆️
panel/tests/test_layout.py 100% <100%> (ø) ⬆️
panel/tests/test_param.py 99.61% <100%> (-0.02%) ⬇️
panel/holoviews.py 83.41% <100%> (ø) ⬆️
panel/pipeline.py 80.82% <100%> (ø) ⬆️
panel/param.py 90.74% <100%> (+0.19%) ⬆️
panel/tests/test_widgets.py 100% <100%> (ø) ⬆️
panel/widgets.py 94.45% <100%> (+0.04%) ⬆️
panel/viewable.py 70.93% <100%> (+1.25%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec649b5...47e7483. Read the comment docs.

@philippjfr philippjfr deleted the bokeh_layout_changes branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants