Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining external JS and CSS resources via config #330

Merged
merged 2 commits into from Mar 24, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 24, 2019

No description provided.

@jbednar
Copy link
Member

@jbednar jbednar commented Mar 24, 2019

Looks good; could use some docs and examples!

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 24, 2019

Added some docs.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 24, 2019

Codecov Report

Merging #330 into master will decrease coverage by 0.07%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   89.55%   89.47%   -0.08%     
==========================================
  Files          84       85       +1     
  Lines        6795     6824      +29     
==========================================
+ Hits         6085     6106      +21     
- Misses        710      718       +8
Impacted Files Coverage Δ
panel/compiler.py 36.11% <0%> (-4.52%) ⬇️
panel/io/resources.py 100% <100%> (ø)
panel/io/__init__.py 100% <100%> (ø) ⬆️
panel/config.py 49.51% <100%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2403468...6ca3904. Read the comment docs.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 24, 2019

Merging, I'd suggest you review the documentation as a whole before release @jbednar.

@philippjfr philippjfr merged commit e67415c into master Mar 24, 2019
3 checks passed
"\n",
" pn.extension('vega', 'katex')\n",
" \n",
"will ensure that the Vega and LaTeX JS dependencies are loaded. Additionally any external ``css_files``, ``js_files`` and ``raw_css`` should be declared in the extension. The ``js_files`` should be declared as a dictionary mapping from the exported JS module name to the URL containing the JS components, while the ``css_files`` can be defined as a list:\n",
Copy link
Member

@jbednar jbednar Mar 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is already merged, but while it's still fresh in your mind, it would be good to clarify the situations where one would need external CSS or JS files.

@philippjfr philippjfr deleted the external_js_css branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants