Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using a 4 tuple of min, max, step, value for interact #334

Merged
merged 3 commits into from Mar 25, 2019

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Mar 25, 2019

Fixes #333

Allows step to be None

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 25, 2019

Looks good to me. Ready to merge?

@jsignell
Copy link
Member Author

@jsignell jsignell commented Mar 25, 2019

I was adding a cell to the interact notebook. Think it's necessary?

@jbednar
Copy link
Member

@jbednar jbednar commented Mar 25, 2019

Yes, please do, because this is functionality beyond what ipywidgets supports and thus won't be expected by many people.

@jsignell jsignell self-assigned this Mar 25, 2019
@jsignell jsignell requested a review from philippjfr Mar 25, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 25, 2019

Codecov Report

Merging #334 into master will increase coverage by 0.05%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   89.42%   89.47%   +0.05%     
==========================================
  Files          85       85              
  Lines        6828     6872      +44     
==========================================
+ Hits         6106     6149      +43     
- Misses        722      723       +1
Impacted Files Coverage Δ
panel/tests/test_interact.py 100% <100%> (ø) ⬆️
panel/interact.py 76.07% <87.5%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df79e9c...c1c6f01. Read the comment docs.

@jsignell
Copy link
Member Author

@jsignell jsignell commented Mar 25, 2019

I did a little formatting cleanup in the options table and cleaned up the notebook state.

Before

Screen Shot 2019-03-25 at 2 19 17 PM

After

Screen Shot 2019-03-25 at 2 21 21 PM

@jsignell
Copy link
Member Author

@jsignell jsignell commented Mar 25, 2019

I'm ready for this to go in now.

Copy link
Member

@jbednar jbednar left a comment

That all looks good. I assume it's deliberate to remove the jupyter-widgets state from Interact.ipynb? Nice to get all that out of there, as long as it's not needed for something.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 25, 2019

Definitely not needed, I think the jq based script ignores it or I was lazy about clearing it.

@philippjfr philippjfr merged commit 12287d2 into master Mar 25, 2019
3 checks passed
@jsignell jsignell deleted the jsignell/interact_4tuple branch Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants