Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace code editor #359

Merged
merged 8 commits into from Apr 3, 2019
Merged

Ace code editor #359

merged 8 commits into from Apr 3, 2019

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Apr 2, 2019

This PR add a panel of type code editor
It's based on this library https://github.com/ajaxorg/ace/

I have activated the language and theme selection
basic autocompletion with ctrl+space
and possibility to add anotations
ezgif com-video-to-gif (6)

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 2, 2019

@xavArtley I'd be happy to merge this once there is a reference gallery entry. At some point we will have to have a discussion which components make sense in panel itself and which could be added somewhere else.

@xavArtley
Copy link
Collaborator Author

@xavArtley xavArtley commented Apr 2, 2019

Indeed I think this model should be external to panel more in some custom extensions

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 2, 2019

We'll need to work out a plan for managing external components like this.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 3, 2019

I'm actually happy to merge this now and move it later if we decide on a repo to extend panel. Does that sound okay @xavArtley ?

@xavArtley
Copy link
Collaborator Author

@xavArtley xavArtley commented Apr 3, 2019

Ok for me

@philippjfr philippjfr merged commit 5770539 into master Apr 3, 2019
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants