Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spinner widget #368

Merged
merged 2 commits into from Apr 11, 2019
Merged

add spinner widget #368

merged 2 commits into from Apr 11, 2019

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Apr 4, 2019

image

@@ -129,6 +129,25 @@ class ColorPicker(Widget):
_rename = {'value': 'color', 'name': 'title'}


class Spinner(Widget):

low = param.Number(default=None, doc="""
Copy link
Member

@philippjfr philippjfr Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make these consistent with other similar widgets and call them start and end.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 10, 2019

Looks great thanks, one minor comment otherwise I'm happy to merge.

@codecov-io
Copy link

@codecov-io codecov-io commented Apr 10, 2019

Codecov Report

Merging #368 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   86.63%   86.64%   +0.01%     
==========================================
  Files          92       92              
  Lines        7884     7891       +7     
==========================================
+ Hits         6830     6837       +7     
  Misses       1054     1054
Impacted Files Coverage Δ
panel/widgets/__init__.py 100% <ø> (ø) ⬆️
panel/widgets/input.py 97.81% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab0749...b84e149. Read the comment docs.

@philippjfr philippjfr merged commit eff3c9e into master Apr 11, 2019
3 checks passed
@philippjfr philippjfr deleted the spinner_widget branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants