Update developer guide #4265
Merged
Update developer guide #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4265 +/- ##
==========================================
- Coverage 82.71% 82.71% -0.01%
==========================================
Files 237 237
Lines 34283 34283
==========================================
- Hits 28358 28357 -1
- Misses 5925 5926 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
approved these changes
Jan 9, 2023
|
I agree. Maybe some inspiration can be taken from Bokeh's workflow. |
philippjfr
pushed a commit
that referenced
this pull request
Jan 16, 2023
* Added SETUPTOOLS_ENABLE_FEATURES to dev guide * Seperate UI test installation * Update test badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spend the better half of an afternoon getting panel to work based on the instructions of the developer guide. The missing piece was
SETUPTOOLS_ENABLE_FEATURES=legacy-editablewhich is what we also do for our test suite:panel/.github/workflows/test.yaml
Line 46 in b2a65c6
When I already was in the file, I updated the instructions for running UI test (fixes #4248), which is what we also do in our tests:
https://github.com/pyviz-dev/holoviz_tasks/blob/bbfbd3696cc27ad370735f121898e5d2c154d273/install/action.yaml#L144-L152