Skip to content

Allow refs on Matplotlib and PaneBase #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Allow refs on Matplotlib and PaneBase #5582

merged 1 commit into from
Oct 4, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 4, 2023

I can see the Gaminder example fails because they are False.

https://github.com/holoviz/panel/actions/runs/6403251613/job/17381429742?pr=5572

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #5582 (5b6d230) into main (49d95f2) will increase coverage by 59.17%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5582       +/-   ##
===========================================
+ Coverage   24.07%   83.25%   +59.17%     
===========================================
  Files         277      277               
  Lines       39591    39591               
===========================================
+ Hits         9533    32962    +23429     
+ Misses      30058     6629    -23429     
Flag Coverage Δ
ui-tests 40.61% <100.00%> (?)
unitexamples-tests 73.34% <100.00%> (+49.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/pane/base.py 84.49% <100.00%> (+60.96%) ⬆️
panel/pane/plot.py 68.69% <100.00%> (+32.60%) ⬆️

... and 223 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@philippjfr philippjfr merged commit aa43812 into main Oct 4, 2023
@philippjfr philippjfr deleted the fix_gapminder branch October 4, 2023 12:56
ahuang11 pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants