Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved fancy layout for scrubber #571

Merged
merged 12 commits into from Aug 7, 2019
Merged

Improved fancy layout for scrubber #571

merged 12 commits into from Aug 7, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 5, 2019

HoloViews pane now offers a number of options for arranging the plot and widgets

left

Screen Shot 2019-08-06 at 10 46 10 AM

top

Screen Shot 2019-08-06 at 10 46 19 AM

right

Screen Shot 2019-08-06 at 10 45 10 AM

bottom

Screen Shot 2019-08-06 at 10 46 02 AM

center_left

Screen Shot 2019-08-06 at 10 46 37 AM

center_top

Screen Shot 2019-08-06 at 10 46 52 AM

center_right

Screen Shot 2019-08-06 at 10 47 09 AM

center_bottom

Screen Shot 2019-08-06 at 10 47 25 AM

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Aug 6, 2019

@jbednar @jlstevens Thinking of renaming the option to widget_layout, how does that sound? Also should I add top_left, top_right, bottom_left, and bottom_right?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Aug 6, 2019

Or maybe should we have separate widget_layout and center parameters?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Aug 6, 2019

The full set of options in that case would be:

center = True/False
widget_layout = top_left, top, top_right, right_top, right, right_bottom, bottom_right, bottom, bottom_left, left_bottom, left, left_top

@jbednar
Copy link
Member

@jbednar jbednar commented Aug 6, 2019

Yes, it seems like the two flags need to be separated if all those other options are supported, or there will be too many combinations. Are those location options identical to what Bokeh supports for legends? If so that sounds reasonable...

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Aug 6, 2019

Are those location options identical to what Bokeh supports for legends? If so that sounds reasonable...

No, bokeh has a relative positioning system for legends which is expressed in pixels (and therefore pretty useless imo).

@philippjfr philippjfr merged commit c241f90 into master Aug 7, 2019
2 of 3 checks passed
@philippjfr philippjfr deleted the philippjfr/fancy_scrubber branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants