Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodic callback example #573

Merged
merged 4 commits into from Aug 9, 2019
Merged

Add periodic callback example #573

merged 4 commits into from Aug 9, 2019

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Aug 6, 2019

random_number_generator
I wasn't really sure where to demonstrate it (reference gallery? user guide?) so I just dumped it under gallery simple examples

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 6, 2019

Thanks, I think that's a good place for this example.

"metadata": {},
"outputs": [],
"source": [
"periodic_cb.stop() # finish generating random numbers automatically"
Copy link
Member

@philippjfr philippjfr Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could you put this behind another button. Right now when you run this as an app (which is how it'll appear in the docs) it will immediately stop the periodic callback.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 7, 2019

Thanks for making the changes and sorry for the last bit of feedback!

@ahuang11
Copy link
Contributor Author

@ahuang11 ahuang11 commented Aug 8, 2019

No problem! The package has been extremely useful

@philippjfr philippjfr merged commit e428564 into holoviz:master Aug 9, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants