Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTK panel scalar array choice correction #605

Merged
merged 1 commit into from Aug 20, 2019
Merged

VTK panel scalar array choice correction #605

merged 1 commit into from Aug 20, 2019

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Aug 19, 2019

Work in progress
Need to test if the correction handle correctly the colormap of the vtk mesh in all case and does not bring regression
Should correct in pyvista/pyvista#268 :

  • pyvista/pyvista-support#15
  • Make sure scalar/color mapping is working - sometimes the mapping is totally wrong. Blood vessels example shows this
  • custom colormaps (see #345) (except we must create a pyvista plotter since mesh.plot(use_panel=True) does not work anymore due to auto_close=True
    image

Concerning :

  • Send text/labels to VTKjs or at least don't throw an error (text added with add_point_labels and add_text)
    For me it does not throw error but the text does not show

@banesullivan it will be great if you could test it

@banesullivan
Copy link
Contributor

@banesullivan banesullivan commented Aug 19, 2019

These changes are great and much needed, thanks @xavArtley! I'll try to check this out and test when I have a minute.

Not to throw a curveball at you, but what if we reshifted focus to expanding itkwidgets and added support for itkwidgets in panel instead of using this VTKjs conversion script? itkwidgets is definitely the path forward for PyVista and it has a few open issues to make it more interactive and easier to treat like a PyVista plotter.

See my comment (pyvista/pyvista#364 (comment)) for some useful info/links to demos of itkwidgets

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 20, 2019

@xavArtley Ready to merge?

@xavArtley
Copy link
Collaborator Author

@xavArtley xavArtley commented Aug 20, 2019

I think so I haven't encounter regressions

@philippjfr philippjfr merged commit 8a879b9 into master Aug 20, 2019
2 of 3 checks passed
@philippjfr philippjfr deleted the vtk_scalar_array branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants