Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PasswordInput widget similar to TextInput #655

Merged
merged 4 commits into from Sep 24, 2019
Merged

Added PasswordInput widget similar to TextInput #655

merged 4 commits into from Sep 24, 2019

Conversation

julwin
Copy link
Contributor

@julwin julwin commented Sep 24, 2019

Added a PasswordInput widget using the Bokeh widget PasswordInput. Did not add to documentation or tests as of now.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 24, 2019

Thanks for this @julwin. Did you forget to push the new file?

@julwin
Copy link
Contributor Author

@julwin julwin commented Sep 24, 2019

Hm I don't know tbh - I only modified panel/widgets/input.py. Am I missing something here?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 24, 2019

Ah, nevermind sorry for the confusion, I didn't realize PasswordInput was an existing model in bokeh. I thought you had implemented a custom model in panel. Ignore me :)

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 24, 2019

Okay, then the only thing we need before merge is a reference notebook like this one for the TextInput widget.

@julwin
Copy link
Contributor Author

@julwin julwin commented Sep 24, 2019

I see 😄 It is a pretty small change after all

@philippjfr philippjfr added the type: feature label Sep 24, 2019
@philippjfr philippjfr added this to the v0.7.0 milestone Sep 24, 2019
@julwin
Copy link
Contributor Author

@julwin julwin commented Sep 24, 2019

@philippjfr thanks - will add the notebook and update.

@julwin
Copy link
Contributor Author

@julwin julwin commented Sep 24, 2019

Done: examples/reference/widgets/PasswordInput.ipynb

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 24, 2019

Sorry should have mentioned this earlier. Please clear the notebook before committing it.

@julwin
Copy link
Contributor Author

@julwin julwin commented Sep 24, 2019

No worries, makes sense 👍

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 24, 2019

Looks good, one small suggestion. Once you apply it I'll merge. Thanks for contributing!

Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
@julwin
Copy link
Contributor Author

@julwin julwin commented Sep 24, 2019

Thanks, will continue to do so. It's a great project 😎

@philippjfr philippjfr merged commit 16ccc5f into holoviz:master Sep 24, 2019
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants