Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vtkvolume model to works with new bokeh build #729

Merged
merged 1 commit into from Nov 1, 2019

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Oct 31, 2019

fix : #728

@mattpap
Copy link
Collaborator

@mattpap mattpap commented Nov 1, 2019

Looks good. I must have overlooked this recent addition when rebasing PR #626. It would be good to test if this and all other models are importable in notebooks and under other embedding methods, especially in light of issue #727. Though I wouldn't block merging this PR on that.

@philippjfr philippjfr merged commit 7e83168 into master Nov 1, 2019
1 of 2 checks passed
@xavArtley xavArtley deleted the vtkvolume_new_bokeh_build branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants