Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.7.0 doc updates #768

Merged
merged 18 commits into from Nov 13, 2019
Merged

V0.7.0 doc updates #768

merged 18 commits into from Nov 13, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Nov 11, 2019

Closes #754

doc/index.rst Outdated Show resolved Hide resolved
examples/getting_started/Introduction.ipynb Outdated Show resolved Hide resolved
@@ -169,14 +228,14 @@
"metadata": {},
"outputs": [],
"source": [
"#sine_panel.show()"
"#occupancy.show()"
Copy link
Member

@jbednar jbednar Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I wonder if we shouldn't use some more generic name here, because I expect that lots of people will use this file as an example. Notice how we had to change "sine_panel" to "occupancy", and users writing their own examples are likely to have to do the same (inviting typing errors) or leave the old name (confusing themselves and readers). Maybe we could call it "row" or "panel" or "app"?

Copy link
Member Author

@philippjfr philippjfr Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's like three versions of the app in this notebook, not clear to me which to rename, whether to reuse names etc. I'll leave it for now.

examples/getting_started/Introduction.ipynb Outdated Show resolved Hide resolved
examples/user_guide/Widgets.ipynb Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 6f629d0 into master Nov 13, 2019
1 of 3 checks passed
@philippjfr philippjfr deleted the v0.7.0_doc_updates branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants