Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Template root handling #826

Merged
merged 6 commits into from Dec 3, 2019

Conversation

@philippjfr
Copy link
Member

philippjfr commented Nov 29, 2019

Recent changes to root handling caused some issues with axis linking. This also simplifies the creation of roots in a Template.

Cc: @dharhas Please test on LSST (I did some initial testing and it seemed to work)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #826 into master will increase coverage by 0.67%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage    69.3%   69.98%   +0.67%     
==========================================
  Files         103      104       +1     
  Lines       10407    10447      +40     
==========================================
+ Hits         7213     7311      +98     
+ Misses       3194     3136      -58
Impacted Files Coverage Δ
panel/pane/holoviews.py 76.47% <100%> (ø) ⬆️
panel/template.py 38.58% <75%> (+38.58%) ⬆️
panel/tests/test_template.py 95.74% <95.74%> (ø)
panel/viewable.py 56.15% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af70697...6c5af23. Read the comment docs.

philippjfr added 2 commits Nov 29, 2019
@philippjfr philippjfr merged commit 088e33c into master Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
sthagen added a commit to sthagen/panel that referenced this pull request Dec 4, 2019
Improve Template root handling (holoviz#826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.