Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt optimizing layout solver #867

Merged
merged 2 commits into from Dec 17, 2019
Merged

Attempt optimizing layout solver #867

merged 2 commits into from Dec 17, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 15, 2019

Attempt at caching layout solver state for HTML model.

@MarcSkovMadsen would you mind trying this PR out? It should give a huge performance speedup for the layout solver but I don't yet know if it has unintended consequences. You'll have to check out the PR and then build the models with pip install -e . or python setup.py develop

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 17, 2019

Going to merge this and test more before release.

@philippjfr philippjfr merged commit cd2c4d3 into master Dec 17, 2019
4 checks passed
@MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 18, 2019

Hi @philippjfr

I've tested the current master branch and

  • All my pytests pass
  • All my pages on the awesome-streamlit.org repo looks as expected in Chrome and Firefox
  • The feel of the website is that its more responsive but I have not timed this.
  • Firefox is still significantly faster than Chrome.
  • There was a glitch. The first time I tested the new branch on master in Firefox it went into some sort of maximized, presentation mode. But F11 could not bring it back to the normal mode and it looked wird. Furthermore it did not maximize the width fully. There was a sort of margin on the left and right of a few pixels wide outside the Firefox window where I could see the background. I could not reproduce this though even though I tried a lot. I didn't take any screenshots because I thought I could do that when I reproduced the issue. My feeling is that this can be ignored. Maybe I hit a key or something. But if you hear this from others then I would get worried.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 18, 2019

Thanks for your testing, it is much appreciated!

The feel of the website is that its more responsive but I have not timed this.

For me it's considerably more responsive but actual timing is difficult.

But if you hear this from others then I would get worried.

I'll look out for this, I'll do some extensive testing before the next release to ensure there haven't been any regressions.

@philippjfr philippjfr deleted the optimized_layout branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants