Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimized HTML model consistently #888

Merged
merged 3 commits into from Dec 19, 2019
Merged

Use optimized HTML model consistently #888

merged 3 commits into from Dec 19, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 18, 2019

So it turns out I hadn't actually used the optimized HTML model consistently throughout so this PR should provide further speedups but also potential to break things.

@MarcSkovMadsen would you mind trying this out again?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 18, 2019

Cc: @dharhas and @timothydmorton any chance you could also give this a spin on the LSST dashboard?

@MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 19, 2019

Hi @philippjfr

Tested with success in Chrome and Firefox on Windows on all pages of the awesome-panel.org code.

Awesome!

@codecov
Copy link

@codecov codecov bot commented Dec 19, 2019

Codecov Report

Merging #888 into master will increase coverage by 15.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #888       +/-   ##
==========================================
+ Coverage   69.72%   85.1%   +15.38%     
==========================================
  Files         104     104               
  Lines       10588   10590        +2     
==========================================
+ Hits         7382    9013     +1631     
+ Misses       3206    1577     -1629
Impacted Files Coverage Δ
panel/tests/pane/test_holoviews.py 99.46% <100%> (ø) ⬆️
panel/tests/pane/test_vega.py 97.36% <100%> (ø) ⬆️
panel/tests/pane/test_markup.py 100% <100%> (ø) ⬆️
panel/pane/markup.py 93.28% <100%> (+42.28%) ⬆️
panel/tests/test_interact.py 100% <100%> (ø) ⬆️
panel/tests/pane/test_plot.py 100% <100%> (ø) ⬆️
panel/tests/test_param.py 99.84% <100%> (ø) ⬆️
panel/pane/image.py 77.94% <100%> (+24.26%) ⬆️
panel/compiler.py 6.25% <0%> (+6.25%) ⬆️
panel/pane/holoviews.py 86.47% <0%> (+11.22%) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3210670...9d960dc. Read the comment docs.

@philippjfr philippjfr merged commit 7d409f5 into master Dec 19, 2019
4 checks passed
@philippjfr philippjfr added this to the v0.8.0 milestone Jan 16, 2020
@philippjfr philippjfr deleted the optimize_html branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants