Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace widget #908

Merged
merged 6 commits into from Dec 25, 2019
Merged

Ace widget #908

merged 6 commits into from Dec 25, 2019

Conversation

kgullikson88
Copy link
Contributor

@kgullikson88 kgullikson88 commented Dec 23, 2019

Adds the Ace editor as a widget. This addresses #864

@codecov
Copy link

@codecov codecov bot commented Dec 23, 2019

Codecov Report

Merging #908 into master will increase coverage by 0.13%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   84.96%   85.09%   +0.13%     
==========================================
  Files         104      106       +2     
  Lines       10636    10669      +33     
==========================================
+ Hits         9037     9079      +42     
+ Misses       1599     1590       -9
Impacted Files Coverage Δ
panel/tests/widgets/test_ace.py 100% <100%> (ø)
panel/widgets/__init__.py 100% <100%> (ø) ⬆️
panel/widgets/ace.py 77.27% <77.27%> (ø)
panel/pane/vtk/vtk.py 53.43% <0%> (+1.05%) ⬆️
panel/interact.py 76.07% <0%> (+2.5%) ⬆️
panel/util.py 92.62% <0%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329b8f3...95fb2b1. Read the comment docs.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 24, 2019

This looks great, thanks so much! Would you do me one favor and clear the notebook and then commit it again?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 25, 2019

Thanks again!

@philippjfr philippjfr merged commit a2cefbd into holoviz:master Dec 25, 2019
2 of 3 checks passed
sthagen added a commit to sthagen/holoviz-panel that referenced this issue Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants