Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that closed tabs update Tabs.objects #973

Merged
merged 2 commits into from Jan 21, 2020
Merged

Ensure that closed tabs update Tabs.objects #973

merged 2 commits into from Jan 21, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 21, 2020

Fixes #621

@codecov
Copy link

@codecov codecov bot commented Jan 21, 2020

Codecov Report

Merging #973 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   85.69%   85.74%   +0.05%     
==========================================
  Files          98       98              
  Lines       11030    11072      +42     
==========================================
+ Hits         9452     9494      +42     
  Misses       1578     1578
Impacted Files Coverage Δ
panel/tests/pane/test_holoviews.py 99.46% <ø> (-0.01%) ⬇️
panel/tests/test_layout.py 100% <100%> (ø) ⬆️
panel/tests/test_server.py 100% <100%> (ø) ⬆️
panel/layout.py 83.76% <100%> (+0.63%) ⬆️
panel/tests/test_reactive.py 100% <100%> (ø) ⬆️
panel/viewable.py 81.52% <100%> (+0.21%) ⬆️
panel/io/notebook.py 62.13% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929ce9e...a4f319b. Read the comment docs.

@philippjfr philippjfr merged commit b5f8f21 into master Jan 21, 2020
4 checks passed
@philippjfr philippjfr deleted the tabs_close branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant