Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HoloViews axis linking across Template roots #980

Merged
merged 1 commit into from Jan 22, 2020
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 22, 2020

In #826 I made some fixes to root handling but because I did some confusing things with a shared root a) plots were rendered too many times and b) you could not link axes across roots.

@timothydmorton @dharhas This one is worth testing on the LSST dashboard. I'm not sure you need to be able to link axes across multiple roots but if you wanted to you can do it again. It should also speed things up a little bit since it no longer renders plots multiple times.

@codecov
Copy link

@codecov codecov bot commented Jan 22, 2020

Codecov Report

Merging #980 into master will decrease coverage by <.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
- Coverage   85.74%   85.74%   -0.01%     
==========================================
  Files          98       98              
  Lines       11072    11077       +5     
==========================================
+ Hits         9494     9498       +4     
- Misses       1578     1579       +1
Impacted Files Coverage Δ
panel/pane/holoviews.py 84.55% <100%> (ø) ⬆️
panel/tests/test_template.py 95.74% <100%> (ø) ⬆️
panel/template.py 70.9% <100%> (+0.53%) ⬆️
panel/io/server.py 40.62% <75%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe26a0...9d32207. Read the comment docs.

@philippjfr philippjfr merged commit cfdecb0 into master Jan 22, 2020
4 checks passed
@philippjfr philippjfr deleted the template_link_axes branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant