Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe version of os.path.isfile #986

Merged
merged 3 commits into from Jan 22, 2020
Merged

Use safe version of os.path.isfile #986

merged 3 commits into from Jan 22, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 22, 2020

Fixes #985

@codecov
Copy link

@codecov codecov bot commented Jan 22, 2020

Codecov Report

Merging #986 into master will increase coverage by 0.09%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
+ Coverage    85.7%   85.79%   +0.09%     
==========================================
  Files          99       99              
  Lines       11239    11246       +7     
==========================================
+ Hits         9632     9649      +17     
+ Misses       1607     1597      -10
Impacted Files Coverage Δ
panel/pane/media.py 70.73% <100%> (-0.2%) ⬇️
panel/pane/image.py 78.51% <100%> (-0.06%) ⬇️
panel/pane/vtk/vtk.py 53.43% <100%> (+1.05%) ⬆️
panel/io/save.py 77.35% <50%> (+1.43%) ⬆️
panel/pane/base.py 89.74% <50%> (-1.8%) ⬇️
panel/util.py 89.26% <78.57%> (+2.3%) ⬆️
panel/interact.py 76.07% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed6293...3a1d016. Read the comment docs.

@philippjfr philippjfr merged commit 9aecd68 into master Jan 22, 2020
3 of 4 checks passed
@philippjfr philippjfr deleted the safe_isfile branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant