Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed usage of old param API in util #992

Merged
merged 1 commit into from Jan 23, 2020
Merged

Fixed usage of old param API in util #992

merged 1 commit into from Jan 23, 2020

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 23, 2020

Discovered while trying to update param API usage in holoviz/holoviews#4201. There may be others so don't merge the PR just yet...

@codecov
Copy link

@codecov codecov bot commented Jan 23, 2020

Codecov Report

Merging #992 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   85.83%   85.71%   -0.13%     
==========================================
  Files          99       99              
  Lines       11260    11260              
==========================================
- Hits         9665     9651      -14     
- Misses       1595     1609      +14
Impacted Files Coverage Δ
panel/util.py 85.9% <100%> (-3.36%) ⬇️
panel/interact.py 73.57% <0%> (-2.5%) ⬇️
panel/pane/vtk/vtk.py 52.38% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318ff5b...cc19b90. Read the comment docs.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 23, 2020

Thanks.

@philippjfr philippjfr merged commit 3ce6faa into master Jan 23, 2020
4 checks passed
@philippjfr philippjfr deleted the param_API_fix branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants