Skip to content

Fix .values()/get_value_generator() dealing with Dynamic params and an updated default value - #1058

Merged
philippjfr merged 1 commit into
mainfrom
fix_values_dyn_param
Jun 11, 2025
Merged

philippjfr merged 1 commit into
mainfrom
fix_values_dyn_param

Conversation

@maximlt

@maximlt maximlt commented May 5, 2025 •

Copy link
Copy Markdown
Member

Fixes #1057

.param.values() uses .param.get_value_generator() under the hood (this looks all overly complicated but that's another issue) to obtain the value of a Parameter. get_value_generator() seems to be designed to deal specifically with Dynamic Parameters (like Integer, Number, etc.), to return the generator callable. So in cases where there's no generator, we simply return the value.

@codecov

codecov Bot commented May 5, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (4c90671) to head (e0f89d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1058   +/-   ##
=======================================
  Coverage   87.45%   87.46%           
=======================================
  Files           9        9           
  Lines        4959     4961    +2     
=======================================
+ Hits         4337     4339    +2     
  Misses        622      622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maximlt maximlt changed the title Fix .values()/get_value_generator() when Fix .values()/get_value_generator() dealing with Dynamic params and an updated default value May 5, 2025
@philippjfr

Copy link
Copy Markdown
Member

Makes sense.

@philippjfr
philippjfr merged commit cbe93b9 into main Jun 11, 2025
@philippjfr
philippjfr deleted the fix_values_dyn_param branch June 11, 2025 13:13
@esolberg-nr

Copy link
Copy Markdown

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behaviour of param.values

3 participants