Repository navigation
Sort docstring by precedence - #445
Merged
Merged
Conversation
jbednar
reviewed
Nov 15, 2020
Contributor
Author
|
Okay thanks for the suggestion. It now follows: https://panel.holoviz.org/gallery/param/precedence.html |
jbednar
reviewed
Nov 16, 2020
jbednar
reviewed
Nov 16, 2020
Contributor
Author
|
Any other changes needed? |
Member
|
Nope; looks great! I think it's ready to merge once the tests are passing. Not sure what's up with those, and probably won't have a chance to look at that today. |
Contributor
Author
|
I wonder if tests are failing because the order changed? |
Contributor
I think that is possible. Otherwise, I like this PR and would be happy to see it merged once the tests are green! |
Member
|
Will merge and fix up the tests separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#443