Add Bytes parameter - #542
Conversation
jbednar
left a comment
There was a problem hiding this comment.
I'm glad to have a Parameter supporting bytes, but could this just be a class_ or type_ or bytes=True argument to String to enforce the the bytes type?
|
Would I be able to use the Bytes parameter in Panels ReactiveHTML to efficiently transfer files or Arrow dataframes between server and client? |
Could look at that for sure but note that |
|
Other than Jim's docstring comment, looks good to me! |
Given that a big part of the whole py3 transition was trying to be clear that strings and bytes are different, I think supporting bytes via a type argument to String in this way would be weird. I think a separate |
18454ac to
ee016d8
Compare
09294f2 to
54ecb52
Compare
jbednar
left a comment
There was a problem hiding this comment.
Looks good! It's a little odd for the unit test to use an IP address instead of something that would be more naturally stored as bytes, but I guess that's fine, so feel free to merge as-is.
5d3b91e to
5307ddf
Compare
5307ddf to
10ab17a
Compare
Implements #408