From 91a0cc14bfa5cf44c861f36d8dbc02f4369157b8 Mon Sep 17 00:00:00 2001 From: Mohamed Barakat Date: Mon, 1 Sep 2025 23:55:08 +0200 Subject: [PATCH 1/2] disambiguate local variables --- LinearClosuresForCAP/gap/LinearClosure.gi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LinearClosuresForCAP/gap/LinearClosure.gi b/LinearClosuresForCAP/gap/LinearClosure.gi index 6c09b34b13..0eab9ac176 100644 --- a/LinearClosuresForCAP/gap/LinearClosure.gi +++ b/LinearClosuresForCAP/gap/LinearClosure.gi @@ -638,7 +638,7 @@ InstallGlobalFunction( INSTALL_FUNCTIONS_FOR_LINEAR_CLOSURE, coeffs := ListX( CoefficientsList( alpha ), CoefficientsList( beta ), { a,b } -> a * b ); - supp := ListX( SupportMorphisms( alpha ), SupportMorphisms( beta ), { alpha, beta } -> PreCompose( underlying_category, alpha, beta ) ); + supp := ListX( SupportMorphisms( alpha ), SupportMorphisms( beta ), { a, b } -> PreCompose( underlying_category, a, b ) ); return MorphismConstructor( cat, Source( alpha ), Pair( coeffs, supp ), Range( beta ) ); From 0ae8fd3ce6f15b3a2123f6bfe22d6ae2f68a9fec Mon Sep 17 00:00:00 2001 From: Mohamed Barakat Date: Mon, 1 Sep 2025 23:56:23 +0200 Subject: [PATCH 2/2] LinearClosureMorphismNC now does a cheap assertion --- LinearClosuresForCAP/PackageInfo.g | 2 +- LinearClosuresForCAP/gap/LinearClosure.gi | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/LinearClosuresForCAP/PackageInfo.g b/LinearClosuresForCAP/PackageInfo.g index 1f30517b04..b6a4bc70bd 100644 --- a/LinearClosuresForCAP/PackageInfo.g +++ b/LinearClosuresForCAP/PackageInfo.g @@ -10,7 +10,7 @@ SetPackageInfo( rec( PackageName := "LinearClosuresForCAP", Subtitle := "Linear closures", -Version := "2025.08-04", +Version := "2025.09-01", Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ), License := "GPL-2.0-or-later", diff --git a/LinearClosuresForCAP/gap/LinearClosure.gi b/LinearClosuresForCAP/gap/LinearClosure.gi index 0eab9ac176..8edfdd37f6 100644 --- a/LinearClosuresForCAP/gap/LinearClosure.gi +++ b/LinearClosuresForCAP/gap/LinearClosure.gi @@ -354,12 +354,17 @@ end ); InstallOtherMethodForCompilerForCAP( LinearClosureMorphismNC, [ IsLinearClosure, IsLinearClosureObject, IsList, IsList, IsLinearClosureObject ], function( category, source, coefficients, support_morphisms, range ) + local underlying_category; + + underlying_category := UnderlyingCategory( category ); + + #% CAP_JIT_DROP_NEXT_STATEMENT + Assert( 0, ForAll( support_morphisms, mor -> IsIdenticalObj( CapCategory( mor ), underlying_category ) ) ); return CreateCapCategoryMorphismWithAttributes( category, - source, range, - CoefficientsList, coefficients, - SupportMorphisms, support_morphisms - ); + source, range, + CoefficientsList, coefficients, + SupportMorphisms, support_morphisms ); end );