Support property names in bulk_set_partial_config_parameters #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firstof9
reviewed
Apr 8, 2021
raman325
added a commit
to raman325/zwave-js-server-python
that referenced
this pull request
Apr 19, 2021
…sistant-libs#188) * Support property names in bulk_set_partial_config_parameters * ignore type error because we know the property key for partial values will always be an int * fix formatting * lint * switch to list comprehension and cast property_key instead of ignoring type
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you provide a dictionary of partial parameter values to set for
bulk_set_partial_config_parameters, it's assumed that the keys are an integer representation of a bitmask. For further convenience, we are adding the ability for users to specify the property name of the partial parameter as the key instead.Note that because most of the logic lives in the library, the only change that is needed on the HA side is a bump in the lib version and a change to the service schema to allow strings to be passed