Replace DWM with Openbox window manager for deCONZ addon#3966
Conversation
The DWM window manager is difficult to use without knowing keyboard commands to control it, e.g.: https://gist.github.com/erlendaakre/12eb90eef84a3ab81f7b531e516c9594 User feedback can be found in: - home-assistant#3708 - https://forum.phoscon.de/t/new-deconz-gui-windows-control-dwm-issues/5097/35 Openbox is a traditional "boring" window manager like Win95. Like DWM it is light weight and also used in the deCONZ community Docker container. This PR was tested in my local setup.
📝 WalkthroughWalkthroughThe update advances the project from version 7.0.0 to 8.0.0. The changelog now documents the new version and notes the switch in the window manager from dwm to openbox. In addition, the Dockerfile has been modified to install openbox instead of dwm, and the configuration file ( Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deconz/Dockerfile (1)
14-14: Dependency update: replacing dwm with openbox.
The Dockerfile now installs openbox instead of dwm, in line with the PR objective. Verify that openbox is available for all target architectures and that its runtime configuration (if any) is correctly handled.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
deconz/CHANGELOG.md(1 hunks)deconz/Dockerfile(1 hunks)deconz/config.yaml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
`*/**(html|markdown|md)`: - For instructional content in doc...
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
deconz/Dockerfiledeconz/config.yamldeconz/CHANGELOG.md
`*/**(html|markdown|md)`: - Use bold to mark UI strings. - I...
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
deconz/Dockerfiledeconz/config.yamldeconz/CHANGELOG.md
`*/**(html|markdown|md)`: - Be brief in your replies and don...
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
deconz/Dockerfiledeconz/config.yamldeconz/CHANGELOG.md
`*/**(html|markdown|md)`: - Use sentence-style capitalizatio...
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
deconz/Dockerfiledeconz/config.yamldeconz/CHANGELOG.md
`*/**(html|markdown|md)`: do not comment on HTML used for ic...
*/**(html|markdown|md): do not comment on HTML used for icons
deconz/Dockerfiledeconz/config.yamldeconz/CHANGELOG.md
`*/**(html|markdown|md)`: Avoid flagging inline HTML for emb...
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.
deconz/Dockerfiledeconz/config.yamldeconz/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build armhf deconz add-on
- GitHub Check: Build aarch64 deconz add-on
🔇 Additional comments (2)
deconz/config.yaml (1)
2-2: Version update to 8.0.0.
The version number is correctly updated. Confirm that any references (e.g., in documentation or linked release notes) are also updated to ensure consistency across the project.deconz/CHANGELOG.md (1)
3-6: Changelog reflects new version and window manager change.
The changelog entry for version 8.0.0 clearly states the switch to openbox. Ensure that this documentation is in sync with other release notes and configuration files.
|
This PR also improves this behavior #3905. |
agners
left a comment
agners
left a comment
There was a problem hiding this comment.
LGTM, also tested locally. Thanks for your PR!
3 participants
The DWM window manager is difficult to use without knowing keyboard commands to control it, e.g.: https://gist.github.com/erlendaakre/12eb90eef84a3ab81f7b531e516c9594
User feedback can be found in:
Openbox is a traditional "boring" window manager like Win95. Like DWM it is light weight and also used in the deCONZ community Docker container.
This PR was tested in my local setup.
Summary by CodeRabbit
New Features
Documentation