Fix device controls crashing System UI on long press #2513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2251 (the functionality, not the System UI crash)
I've commented on the reason for these changes on the Google issue tracker, but the short version is: due to a security-related change the app needs to provide unique, mutable
PendingIntent
s to the system for the device control app intents.Tested on a device with Android 11 + an emulator with Android 12 on the November 2021 security patch (to make sure controls still work as they did before on those versions), as well as a device with Android 12 on the May 2022 security patch (to see if the changes 'fix' the issue).
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes