Catch exceptions during app registration #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catch any exceptions thrown during app registration (after webview login) instead of crashing. There should only be a few errors possible here that are not encountered in the webview. - Set dialog theme to fix background on API <31
dshokouhi
approved these changes
May 21, 2022
JBassett
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles any exceptions thrown after logging in to Home Assistant while doing initial registration of the app (issue #2519), by asking the user to check their configuration.
I've also updated the launch screen theme's AlertDialog theme to remove the Home Assistant logo as the dialog's background on API < 31.
Screenshots
Link to pull request in Documentation repository
n/a
Any other notes
The next step to really fix/solve #2519 would be to bundle an up-to-date version of Conscrypt with the app for OkHttp. I'm not including that here because it would create a conflict with #2526, let's allow that to be merged first.