Add logged out state to Wear tiles #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a generic tile to be used when the Wear app isn't logged in - Simplify tile root layout building using Timeline.fromLayoutElement
JBassett
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a generic tile design to be used when the Wear app isn't logged in based on the Dialog design as recommended: "In some cases, the user needs to (...) sign in (...) to see content on a Tile. Use dialogs to prompt users to take an action.".
Implements #3383
Screenshots
Link to pull request in Documentation repository
n/a
Any other notes
I'm using the Material Tiles layouts which fit in with Google's tile designs. It might be nice to update the empty states with the same text/button styles for consistency but that's out of scope for this PR.