Skip to content

Add dark variant for OpenWrt - #5374

Merged
frenck merged 1 commit into
home-assistant:masterfrom
Smankusors:master
Apr 22, 2024
Merged

Add dark variant for OpenWrt#5374
frenck merged 1 commit into
home-assistant:masterfrom
Smankusors:master

Conversation

@Smankusors

@Smankusors Smankusors commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

Proposed change

The images are from the https://github.com/openwrt/branding

I decided to use the white and blue as a dark variant so that it's consistent with the rest of HA blue logos, wdyt?

before after
before after

I also updated the light logo variant according to that repo so that it's consistent with the new dark variant

I wonder since there are identical images from core_brands and custom_integrations, shall I create a symlink? Like the existing core integrations of ubus and luci?
Or should I left these core_brands and custom_integrations as is?
nvm, I read the README, the custom_integrations should not symlink to the core_brands

Thanks,

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

also updated the light logo variant according to the official branding

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Smankusors 馃憤

../Frenck

@frenck
frenck merged commit 3893d2a into home-assistant:master Apr 22, 2024
Athozs pushed a commit to Athozs/brands that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants