Add dark variant for OpenWrt - #5374
Merged
Merged
Conversation
also updated the light logo variant according to the official branding
frenck
approved these changes
Apr 22, 2024
frenck
left a comment
Member
There was a problem hiding this comment.
Thanks, @Smankusors 馃憤
../Frenck
Athozs
pushed a commit
to Athozs/brands
that referenced
this pull request
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The images are from the https://github.com/openwrt/branding
I decided to use the white and blue as a dark variant so that it's consistent with the rest of HA blue logos, wdyt?
I also updated the light logo variant according to that repo so that it's consistent with the new dark variant
I wonder since there are identical images from core_brands and custom_integrations, shall I create a symlink? Like the existing core integrations of ubus and luci?Or should I left these core_brands and custom_integrations as is?nvm, I read the README, the custom_integrations should not symlink to the core_brands
Thanks,
Type of change
Python wheels repository
Additional information
Checklist
icon.png)icon@2x.png)logo.png)logo@2x.png)