From 6bb685eabac5a92a6f57a547d221c42ed85a2a3e Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Fri, 29 Apr 2022 21:42:45 +0200 Subject: [PATCH] Use LightEntityFeature enum in smartthings (#71057) --- homeassistant/components/smartthings/light.py | 9 ++++++--- tests/components/smartthings/test_light.py | 11 +++++++---- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/homeassistant/components/smartthings/light.py b/homeassistant/components/smartthings/light.py index 794a902e941e4c..1b1738a94d4283 100644 --- a/homeassistant/components/smartthings/light.py +++ b/homeassistant/components/smartthings/light.py @@ -14,8 +14,8 @@ SUPPORT_BRIGHTNESS, SUPPORT_COLOR, SUPPORT_COLOR_TEMP, - SUPPORT_TRANSITION, LightEntity, + LightEntityFeature, ) from homeassistant.config_entries import ConfigEntry from homeassistant.core import HomeAssistant @@ -86,7 +86,7 @@ def _determine_features(self): features = 0 # Brightness and transition if Capability.switch_level in self._device.capabilities: - features |= SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION + features |= SUPPORT_BRIGHTNESS | LightEntityFeature.TRANSITION # Color Temperature if Capability.color_temperature in self._device.capabilities: features |= SUPPORT_COLOR_TEMP @@ -124,7 +124,10 @@ async def async_turn_on(self, **kwargs) -> None: async def async_turn_off(self, **kwargs) -> None: """Turn the light off.""" # Switch/transition - if self._supported_features & SUPPORT_TRANSITION and ATTR_TRANSITION in kwargs: + if ( + self._supported_features & LightEntityFeature.TRANSITION + and ATTR_TRANSITION in kwargs + ): await self.async_set_level(0, int(kwargs[ATTR_TRANSITION])) else: await self._device.switch_off(set_status=True) diff --git a/tests/components/smartthings/test_light.py b/tests/components/smartthings/test_light.py index 166b0606b66c7f..0fff14039854f7 100644 --- a/tests/components/smartthings/test_light.py +++ b/tests/components/smartthings/test_light.py @@ -16,7 +16,7 @@ SUPPORT_BRIGHTNESS, SUPPORT_COLOR, SUPPORT_COLOR_TEMP, - SUPPORT_TRANSITION, + LightEntityFeature, ) from homeassistant.components.smartthings.const import DOMAIN, SIGNAL_SMARTTHINGS_UPDATE from homeassistant.config_entries import ConfigEntryState @@ -82,7 +82,7 @@ async def test_entity_state(hass, light_devices): assert state.state == "on" assert ( state.attributes[ATTR_SUPPORTED_FEATURES] - == SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION + == SUPPORT_BRIGHTNESS | LightEntityFeature.TRANSITION ) assert isinstance(state.attributes[ATTR_BRIGHTNESS], int) assert state.attributes[ATTR_BRIGHTNESS] == 255 @@ -92,7 +92,7 @@ async def test_entity_state(hass, light_devices): assert state.state == "off" assert ( state.attributes[ATTR_SUPPORTED_FEATURES] - == SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION | SUPPORT_COLOR + == SUPPORT_BRIGHTNESS | LightEntityFeature.TRANSITION | SUPPORT_COLOR ) # Color Dimmer 2 @@ -100,7 +100,10 @@ async def test_entity_state(hass, light_devices): assert state.state == "on" assert ( state.attributes[ATTR_SUPPORTED_FEATURES] - == SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION | SUPPORT_COLOR | SUPPORT_COLOR_TEMP + == SUPPORT_BRIGHTNESS + | LightEntityFeature.TRANSITION + | SUPPORT_COLOR + | SUPPORT_COLOR_TEMP ) assert state.attributes[ATTR_BRIGHTNESS] == 255 assert state.attributes[ATTR_HS_COLOR] == (273.6, 55.0)