From b362d30ec71b9983a8a27771d1ac2f9f6d365988 Mon Sep 17 00:00:00 2001 From: joostlek Date: Tue, 24 Oct 2023 00:19:33 +0200 Subject: [PATCH] Add serial number to Blink --- homeassistant/components/blink/alarm_control_panel.py | 2 +- homeassistant/components/blink/binary_sensor.py | 6 ++++-- homeassistant/components/blink/camera.py | 1 + homeassistant/components/blink/sensor.py | 6 ++++-- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/blink/alarm_control_panel.py b/homeassistant/components/blink/alarm_control_panel.py index c789d7cdd6f8f1..d1fcb889fb858c 100644 --- a/homeassistant/components/blink/alarm_control_panel.py +++ b/homeassistant/components/blink/alarm_control_panel.py @@ -60,12 +60,12 @@ def __init__( self.api: Blink = coordinator.api self._coordinator = coordinator self.sync = sync - self._name: str = name self._attr_unique_id: str = sync.serial self._attr_device_info = DeviceInfo( identifiers={(DOMAIN, sync.serial)}, name=f"{DOMAIN} {name}", manufacturer=DEFAULT_BRAND, + serial_number=sync.serial, ) self._update_attr() diff --git a/homeassistant/components/blink/binary_sensor.py b/homeassistant/components/blink/binary_sensor.py index 65e454e44342c7..47b45e2f4eccbb 100644 --- a/homeassistant/components/blink/binary_sensor.py +++ b/homeassistant/components/blink/binary_sensor.py @@ -72,9 +72,11 @@ def __init__( super().__init__(coordinator) self.entity_description = description self._camera = coordinator.api.cameras[camera] - self._attr_unique_id = f"{self._camera.serial}-{description.key}" + serial = self._camera.serial + self._attr_unique_id = f"{serial}-{description.key}" self._attr_device_info = DeviceInfo( - identifiers={(DOMAIN, self._camera.serial)}, + identifiers={(DOMAIN, serial)}, + serial_number=serial, name=camera, manufacturer=DEFAULT_BRAND, model=self._camera.camera_type, diff --git a/homeassistant/components/blink/camera.py b/homeassistant/components/blink/camera.py index 4ff0ba86db9481..31c4e4a563eda8 100644 --- a/homeassistant/components/blink/camera.py +++ b/homeassistant/components/blink/camera.py @@ -58,6 +58,7 @@ def __init__(self, coordinator: BlinkUpdateCoordinator, name, camera) -> None: self._attr_unique_id = f"{camera.serial}-camera" self._attr_device_info = DeviceInfo( identifiers={(DOMAIN, camera.serial)}, + serial_number=camera.serial, name=name, manufacturer=DEFAULT_BRAND, model=camera.camera_type, diff --git a/homeassistant/components/blink/sensor.py b/homeassistant/components/blink/sensor.py index 9453d3b6d6b513..064ad9d04f2210 100644 --- a/homeassistant/components/blink/sensor.py +++ b/homeassistant/components/blink/sensor.py @@ -74,14 +74,16 @@ def __init__( self.entity_description = description self._camera = coordinator.api.cameras[camera] - self._attr_unique_id = f"{self._camera.serial}-{description.key}" + serial = self._camera.serial + self._attr_unique_id = f"{serial}-{description.key}" self._sensor_key = ( "temperature_calibrated" if description.key == "temperature" else description.key ) self._attr_device_info = DeviceInfo( - identifiers={(DOMAIN, self._camera.serial)}, + identifiers={(DOMAIN, serial)}, + serial_number=serial, name=f"{DOMAIN} {camera}", manufacturer=DEFAULT_BRAND, model=self._camera.camera_type,