✨ Support TARGET_TEMPERATURE_RANGE for water heater entities #102960
Conversation
This patch allows to set temperature_target_{high, low} with
`water_heater.set_temperature` service.
Those values were already present before this patch but could not be set
with a service.
This patch changes the default WaterHeaterEntityFeature to include
TARGET_TEMPERATURE to be fully backward compatible.
This is heavily inspired by the same behavior on ClimateEntity.
This patch opens the way for the UI to expose/update high/low temperature targets.
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
This requires a architectural discussion to take place before such feature is added.
Please open a discussion here and once that is approved this PR can be reopened.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@gjohansson-ST , I've opened home-assistant/architecture#995 but don't get feedback for now. Could you guide me further if there a need to do something else to have the discussion started? |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
I'd be glad to keep this open and get some feedback :) |
|
No need to keep open until the architectural discussion has been decided upon. |
|
Thanks for your comment, do you know how I can get feedback on the architectural discussion? |
|
The interesting thing is that the entity already have high and low temperature attributes: https://developers.home-assistant.io/docs/core/entity/water-heater/ |
|
Yes, those values were already present before this patch but could not be set with a service. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
PR is still relevant. I'll keep it open until there is a consensus on the related architecture discussion. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Expected changes:
set_temperaturemight not containtemperaturefield anymore but can containtarget_temp_highandtarget_temp_lowinstead.State of water_heater entities will not contain
target_temp_highandtarget_temp_lowunless those features are explicitly supported.Proposed change
This patch allows to set temperature_target_{high, low} with
water_heater.set_temperatureservice.Those values were already present before this patch but could not be set with a service.
This patch changes the default WaterHeaterEntityFeature to include TARGET_TEMPERATURE to be fully backward compatible.
This is heavily inspired by the same behavior on ClimateEntity.
This patch opens the way for the UI to expose/update high/low temperature targets.
See home-assistant/architecture#995
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: