From 3ab984fb1cdff8a93c615f0ed57d6a845da7f001 Mon Sep 17 00:00:00 2001 From: Simone Chemelli Date: Wed, 10 Jan 2024 17:26:27 +0000 Subject: [PATCH] Fix nor logged edge cases for Comelit VEDO --- homeassistant/components/comelit/coordinator.py | 8 ++------ homeassistant/components/comelit/manifest.json | 2 +- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- 4 files changed, 5 insertions(+), 9 deletions(-) diff --git a/homeassistant/components/comelit/coordinator.py b/homeassistant/components/comelit/coordinator.py index 6559e2ffb876a..4ff75ba530748 100644 --- a/homeassistant/components/comelit/coordinator.py +++ b/homeassistant/components/comelit/coordinator.py @@ -81,15 +81,11 @@ async def _async_update_data(self) -> dict[str, Any]: try: await self.api.login() return await self._async_update_system_data() - except exceptions.CannotConnect as err: - _LOGGER.warning("Connection error for %s", self._host) - await self.api.close() - raise UpdateFailed(f"Error fetching data: {repr(err)}") from err + except (exceptions.CannotConnect, exceptions.CannotRetrieveData) as err: + raise UpdateFailed(repr(err)) from err except exceptions.CannotAuthenticate: raise ConfigEntryAuthFailed - return {} - @abstractmethod async def _async_update_system_data(self) -> dict[str, Any]: """Class method for updating data.""" diff --git a/homeassistant/components/comelit/manifest.json b/homeassistant/components/comelit/manifest.json index 8b50ccdf767cd..8c47564b1655a 100644 --- a/homeassistant/components/comelit/manifest.json +++ b/homeassistant/components/comelit/manifest.json @@ -6,5 +6,5 @@ "documentation": "https://www.home-assistant.io/integrations/comelit", "iot_class": "local_polling", "loggers": ["aiocomelit"], - "requirements": ["aiocomelit==0.7.0"] + "requirements": ["aiocomelit==0.7.3"] } diff --git a/requirements_all.txt b/requirements_all.txt index dbf6af74eaaef..615adcf4fbe1a 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -215,7 +215,7 @@ aiobafi6==0.9.0 aiobotocore==2.6.0 # homeassistant.components.comelit -aiocomelit==0.7.0 +aiocomelit==0.7.3 # homeassistant.components.dhcp aiodiscover==1.6.0 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index bfe06e514a6aa..2f1e8f18ee4df 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -194,7 +194,7 @@ aiobafi6==0.9.0 aiobotocore==2.6.0 # homeassistant.components.comelit -aiocomelit==0.7.0 +aiocomelit==0.7.3 # homeassistant.components.dhcp aiodiscover==1.6.0